-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements more asserts and reading testcases from json files #3399
Conversation
…missing Bluetooth.println)
I think this is now ok to merge. It is only missing a merged espruino/EspruinoAppLoaderCore#61 and the update of |
Thanks - I've merged #3410 which brings in those app loader core changes. Will leave to @gfwilliams to approve with this being a reasonably central change. Unrelated / for another time, but I wonder whether we attempt to run the app tests as part of CI, wdyt? |
Co-authored-by: Rob Pilling <[email protected]>
This looks great - thanks for your work on it! |
I think that would be great. Don't know if we would hit some github limits when we get to a substantial amount of tests, but generally that should be a good idea. |
Yes, I think at some point it'd be great to enable these. At least when it's just a few apps it's not going to be a huge amount of extra CPU use. |
This is mostly a base for discussion in https://forum.espruino.com/conversations/395324/ and extends the
runapptests.js
by @gfwilliams .