Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements more asserts and reading testcases from json files #3399

Merged
merged 33 commits into from
May 10, 2024

Conversation

halemmerich
Copy link
Collaborator

This is mostly a base for discussion in https://forum.espruino.com/conversations/395324/ and extends the runapptests.js by @gfwilliams .

@halemmerich halemmerich marked this pull request as ready for review May 9, 2024 20:48
@halemmerich
Copy link
Collaborator Author

I think this is now ok to merge. It is only missing a merged espruino/EspruinoAppLoaderCore#61 and the update of core to pull the change into this repo.

@bobrippling
Copy link
Collaborator

Thanks - I've merged #3410 which brings in those app loader core changes. Will leave to @gfwilliams to approve with this being a reasonably central change.

Unrelated / for another time, but I wonder whether we attempt to run the app tests as part of CI, wdyt?

bin/runapptests.js Outdated Show resolved Hide resolved
Co-authored-by: Rob Pilling <[email protected]>
@gfwilliams
Copy link
Member

This looks great - thanks for your work on it!

@gfwilliams gfwilliams merged commit 5e312b3 into espruino:master May 10, 2024
1 check passed
@halemmerich
Copy link
Collaborator Author

halemmerich commented May 11, 2024

Unrelated / for another time, but I wonder whether we attempt to run the app tests as part of CI, wdyt?

I think that would be great. Don't know if we would hit some github limits when we get to a substantial amount of tests, but generally that should be a good idea.

@halemmerich halemmerich deleted the gpstests branch May 11, 2024 21:55
@gfwilliams
Copy link
Member

Yes, I think at some point it'd be great to enable these. At least when it's just a few apps it's not going to be a huge amount of extra CPU use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants